[Draft] Implement Deletes for FlatPostgresCollection#270
Open
suddendust wants to merge 5 commits intohypertrace:mainfrom
Open
[Draft] Implement Deletes for FlatPostgresCollection#270suddendust wants to merge 5 commits intohypertrace:mainfrom
suddendust wants to merge 5 commits intohypertrace:mainfrom
Conversation
suddendust
requested review from
avinashkolluru,
kotharironak,
skjindal93 and
suresh-prakash
as code owners
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #270 +/- ##
============================================
+ Coverage 80.44% 80.50% +0.05%
Complexity 1396 1396
============================================
Files 239 239
Lines 6598 6652 +54
Branches 605 607 +2
============================================
+ Hits 5308 5355 +47
- Misses 888 893 +5
- Partials 402 404 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
suddendust
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: Implement Delete Operations for Flat PostgreSQL Collections
Methods Implemented
Why Deprecate delete(Filter filter)?
The legacy Filter class uses hardcoded JSONB document access patterns that don't work with flat collections where fields are direct PostgreSQL columns. The parsing logic assumes nested document structure.
Why New delete(query.Filter filter)?
The new query.Filter wraps FilterTypeExpression which: